Issue 6492085: ASan: Continue after error -- llvm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492085: ASan: Continue after error -- llvm

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by reidw

Modified:
11 years, 8 months ago

Reviewers:
kcc1

Base URL:
http://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Description

Continue after an error in AddressSanitizer -- LLVM half.

Patch Set 1 : Keep Going in LLVM #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
		lib/Transforms/Instrumentation/AddressSanitizer.cpp	View		3 chunks	+12 lines, -2 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

kcc1

11 years, 8 months ago (2012-09-06 13:26:31 UTC) #1

The patch is OK. 
Let's continue discussing if we really need the functionality...

https://codereview.appspot.com/6492085/diff/4001/lib/Transforms/Instrumentati...
File lib/Transforms/Instrumentation/AddressSanitizer.cpp (right):

https://codereview.appspot.com/6492085/diff/4001/lib/Transforms/Instrumentati...
lib/Transforms/Instrumentation/AddressSanitizer.cpp:502: if (!ClKeepGoing)
better two write 
  if (x) 
    if-true
  else
    if-false

https://codereview.appspot.com/6492085/diff/4001/lib/Transforms/Instrumentati...
lib/Transforms/Instrumentation/AddressSanitizer.cpp:769: if (ClKeepGoing)
better write something like 
  const char *ReportPrefix = ClKeepGoing ? 
      kAsanReportWarningTemplate: kAsanReportErrorTemplate

Expand All Messages | Collapse All Messages