Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 6490099: code review 6490099: image/png: optimize encoding image.Gray and image.NRGBA... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by nigeltao
Modified:
9 years, 11 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

image/png: optimize encoding image.Gray and image.NRGBA images. benchmark old ns/op new ns/op delta BenchmarkEncodeGray 23616080 5624558 -76.18% BenchmarkEncodeNRGBOpaque 34181260 17144380 -49.84% BenchmarkEncodeNRGBA 41235820 20345990 -50.66% BenchmarkEncodePaletted 5594652 5620362 +0.46% BenchmarkEncodeRGBOpaque 17242210 17168820 -0.43% BenchmarkEncodeRGBA 66515720 67243560 +1.09%

Patch Set 1 #

Patch Set 2 : diff -r 9e5a84e0fa57 https://code.google.com/p/go #

Patch Set 3 : diff -r 9e5a84e0fa57 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r b3c1f7e35083 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -21 lines) Patch
M src/pkg/image/png/writer.go View 1 3 chunks +41 lines, -20 lines 0 comments Download
M src/pkg/image/png/writer_test.go View 1 2 3 2 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 11 months ago (2012-09-10 05:37:03 UTC) #1
r
LGTM http://codereview.appspot.com/6490099/diff/4001/src/pkg/image/png/writer_test.go File src/pkg/image/png/writer_test.go (right): http://codereview.appspot.com/6490099/diff/4001/src/pkg/image/png/writer_test.go#newcode138 src/pkg/image/png/writer_test.go:138: b.Fatal("expected image to not be opaque") s/to not/not ...
9 years, 11 months ago (2012-09-12 04:13:05 UTC) #2
nigeltao
9 years, 11 months ago (2012-09-13 05:47:39 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f2cdaa74b232 ***

image/png: optimize encoding image.Gray and image.NRGBA images.

benchmark                    old ns/op    new ns/op    delta
BenchmarkEncodeGray           23616080      5624558  -76.18%
BenchmarkEncodeNRGBOpaque     34181260     17144380  -49.84%
BenchmarkEncodeNRGBA          41235820     20345990  -50.66%
BenchmarkEncodePaletted        5594652      5620362   +0.46%
BenchmarkEncodeRGBOpaque      17242210     17168820   -0.43%
BenchmarkEncodeRGBA           66515720     67243560   +1.09%

R=r
CC=golang-dev
http://codereview.appspot.com/6490099
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b