Issue 6490075: Uniter now sets unit addresses on launch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6490075: Uniter now sets unit addresses on launch

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by fwereade

Modified:
11 years, 8 months ago

Reviewers:
mp+122687

Visibility:
Public.

Description

Uniter now sets unit addresses on launch https://code.launchpad.net/~fwereade/juju-core/uniter-store-addresses/+merge/122687 (do not edit description out of merge proposal)

Patch Set 2 : Uniter now sets unit addresses on launch #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/modes.go	View		2 chunks	+22 lines, -0 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	1	3 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TheMue

On 2012/09/04 14:01:00, fwereade wrote: > Please take a look. LGTM

11 years, 8 months ago (2012-09-05 11:42:13 UTC) #2

niemeyer

Nicely done. LGTM https://codereview.appspot.com/6490075/diff/1/worker/uniter/modes.go File worker/uniter/modes.go (right): https://codereview.appspot.com/6490075/diff/1/worker/uniter/modes.go#newcode23 worker/uniter/modes.go:23: log.Printf("updating unit addresses") Pleasantly straightforward logic ...

11 years, 8 months ago (2012-09-05 13:11:31 UTC) #3

fwereade

11 years, 8 months ago (2012-09-06 06:48:02 UTC) #4

*** Submitted:

Uniter now sets unit addresses on launch

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6490075

https://codereview.appspot.com/6490075/diff/1/worker/uniter/uniter_test.go
File worker/uniter/uniter_test.go (right):

https://codereview.appspot.com/6490075/diff/1/worker/uniter/uniter_test.go#ne...
worker/uniter/uniter_test.go:359: timeout := time.After(1000 * time.Millisecond)
On 2012/09/05 13:11:31, niemeyer wrote:
> 1 * time.Second? :-)

Done.

https://codereview.appspot.com/6490075/diff/1/worker/uniter/uniter_test.go#ne...
worker/uniter/uniter_test.go:364: case <-time.After(200 * time.Millisecond):
On 2012/09/05 13:11:31, niemeyer wrote:
> s/200/50/; it's fine to spin a bit faster in exchange for responsiveness in
this
> case.

Done.

Expand All Messages | Collapse All Messages