Issue 6490049: environs/ec2: log open/close port details

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6490049: environs/ec2: log open/close port details (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dave

Modified:
11 years, 8 months ago

Reviewers:
mp+121745

Visibility:
Public.

Description

environs/ec2: log open/close port details https://bugs.launchpad.net/juju-core/+bug/1042073 Added logging of security group name to successful open/close port operation. https://code.launchpad.net/~dave-cheney/juju-core/077-environs-ec2-log-security-group-details/+merge/121745 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : environs/ec2: log open/close port details #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/ec2/ec2.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6490049/diff/1/environs/ec2/ec2.go File environs/ec2/ec2.go (right): https://codereview.appspot.com/6490049/diff/1/environs/ec2/ec2.go#newcode603 environs/ec2/ec2.go:603: log.Printf("environs/ec2: opened %d port(s) in security group %s", ...

11 years, 8 months ago (2012-08-29 19:58:56 UTC) #2

dave_cheney.net

11 years, 8 months ago (2012-08-29 23:09:18 UTC) #3

*** Submitted:

environs/ec2: log open/close port details

https://bugs.launchpad.net/juju-core/+bug/1042073

Added logging of security group name to successful 
open/close port operation.

R=niemeyer
CC=
https://codereview.appspot.com/6490049

https://codereview.appspot.com/6490049/diff/1/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/6490049/diff/1/environs/ec2/ec2.go#newcode603
environs/ec2/ec2.go:603: log.Printf("environs/ec2: opened %d port(s) in security
group %s", len(ports), g.Name)
On 2012/08/29 19:58:56, niemeyer wrote:
> The Port type seems pleasant enough for us to print it:
> 
> log.Printf("opened ports in EC2 security group %q: %v", g.Name, ports)

Done.

https://codereview.appspot.com/6490049/diff/1/environs/ec2/ec2.go#newcode619
environs/ec2/ec2.go:619: log.Printf("environs/ec2: closed %d port(s) in security
group %s", len(ports), g.Name)
On 2012/08/29 19:58:56, niemeyer wrote:
> log.Printf("closed ports in EC2 security group %q: %v", g.Name, ports)

Done.

Expand All Messages | Collapse All Messages