Issue 6489133: mstate: implement unit ports methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489133: mstate: implement unit ports methods

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by rog

Modified:
12 years, 6 months ago

Reviewers:
mp+124679

Visibility:
Public.

Description

mstate: implement unit ports methods https://code.launchpad.net/~rogpeppe/juju-core/068-mstate-ports/+merge/124679 (do not edit description out of merge proposal)

Patch Set 2 : mstate: implement unit ports methods #

Total comments: 2

Patch Set 3 : mstate: implement unit ports methods #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/unit.go	View	1 2	3 chunks	+62 lines, -2 lines	0 comments	Download
M	state/unit_test.go	View	1 2	1 chunk	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

LGTM with the two trivials: https://codereview.appspot.com/6489133/diff/2001/mstate/unit.go File mstate/unit.go (right): https://codereview.appspot.com/6489133/diff/2001/mstate/unit.go#newcode271 mstate/unit.go:271: Assert: D{{"life", Alive}}, I ...

12 years, 6 months ago (2012-09-17 15:01:47 UTC) #3

rog

12 years, 6 months ago (2012-09-20 09:37:33 UTC) #4

*** Submitted:

mstate: implement unit ports methods

R=aram, niemeyer
CC=
https://codereview.appspot.com/6489133

Expand All Messages | Collapse All Messages