Issue 6489111: mstate: use Dead channels rather than Dying for watcher and presence

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489111: mstate: use Dead channels rather than Dying for watcher and presence

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+123748, rog

Visibility:
Public.

Description

mstate: use Dead channels rather than Dying for watcher and presence https://code.launchpad.net/~niemeyer/juju-core/mstate-dying-to-dead/+merge/123748 (do not edit description out of merge proposal)

Patch Set 2 : mstate: use Dead channels rather than Dying for watcher and presence #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mstate/machine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mstate/presence/presence.go	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	mstate/presence/presence_test.go	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	mstate/unit.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mstate/watcher.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	mstate/watcher/watcher.go	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	mstate/watcher/watcher_test.go	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go File mstate/presence/presence.go (right): https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go#newcode118 mstate/presence/presence.go:118: // Dead returns a channel that is closed ...

11 years, 7 months ago (2012-09-11 13:56:34 UTC) #2

niemeyer

11 years, 7 months ago (2012-09-11 14:02:30 UTC) #3

*** Submitted:

mstate: use Dead channels rather than Dying for watcher and presence

R=rog
CC=
https://codereview.appspot.com/6489111

https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go
File mstate/presence/presence.go (right):

https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go#new...
mstate/presence/presence.go:118: // Dead returns a channel that is closed when
the watcher is stopped.
On 2012/09/11 13:56:34, rog wrote:
> s/is stopped/has stopped/ ?

Done.

Expand All Messages | Collapse All Messages