Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(675)

Issue 6489111: mstate: use Dead channels rather than Dying for watcher and presence

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by niemeyer
Modified:
10 years, 2 months ago
Reviewers:
mp+123748, rog
Visibility:
Public.

Description

mstate: use Dead channels rather than Dying for watcher and presence https://code.launchpad.net/~niemeyer/juju-core/mstate-dying-to-dead/+merge/123748 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : mstate: use Dead channels rather than Dying for watcher and presence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mstate/machine.go View 1 chunk +1 line, -1 line 0 comments Download
M mstate/presence/presence.go View 1 1 chunk +3 lines, -4 lines 0 comments Download
M mstate/presence/presence_test.go View 1 chunk +5 lines, -5 lines 0 comments Download
M mstate/unit.go View 1 chunk +1 line, -1 line 0 comments Download
M mstate/watcher.go View 2 chunks +2 lines, -2 lines 0 comments Download
M mstate/watcher/watcher.go View 1 1 chunk +3 lines, -4 lines 0 comments Download
M mstate/watcher/watcher_test.go View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
10 years, 2 months ago (2012-09-11 13:54:09 UTC) #1
rog
LGTM https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go File mstate/presence/presence.go (right): https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go#newcode118 mstate/presence/presence.go:118: // Dead returns a channel that is closed ...
10 years, 2 months ago (2012-09-11 13:56:34 UTC) #2
niemeyer
10 years, 2 months ago (2012-09-11 14:02:30 UTC) #3
*** Submitted:

mstate: use Dead channels rather than Dying for watcher and presence

R=rog
CC=
https://codereview.appspot.com/6489111

https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go
File mstate/presence/presence.go (right):

https://codereview.appspot.com/6489111/diff/1/mstate/presence/presence.go#new...
mstate/presence/presence.go:118: // Dead returns a channel that is closed when
the watcher is stopped.
On 2012/09/11 13:56:34, rog wrote:
> s/is stopped/has stopped/ ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b