Issue 6489083: combine charm and hook states as uniter state
Descriptioncombine charm and hook states as uniter state
charm.Manager and hook.StateFile have together been replaced by charm.Deployer
and uniter.StateFile.
The bits of charm.Manager that were not already subsumed by charm.Deployer
moved into uniter.StateFile, as did everything in hook.StateFile; the
overriding benefit of doing this is that it allows us to switch atomically
from a deploying state into a queued-hook state at the end of Uniter.deploy.
The addition of StateFile is technically independent, but I feel it's useful
to see the change as a *move* of the local-state-saving code; apart from those
additions/deletions, the primary feature is a rewritten Uniter.deploy; the
state-reading changes in modes.go are largely mechanical, apart from the move
of a chunk of ModeInit into ModeContinue (because we can now determine
everything about what mode we should be in purely from the state file, there
is no longer any reason to split it across two modes; and ModeInit can keep
doing things that really are about initialization).
In short: don't fear the diff :).
https://code.launchpad.net/~fwereade/juju-core/uniter-use-deployer/+merge/122838
Requires: https://code.launchpad.net/~fwereade/juju-core/uniter-charm-deployer/+merge/122807
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : combine charm and hook states as uniter state #Patch Set 3 : combine charm and hook states as uniter state #
Total comments: 21
Patch Set 4 : combine charm and hook states as uniter state #Patch Set 5 : combine charm and hook states as uniter state #
MessagesTotal messages: 6
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
