Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 6489075: code review 6489075: doc: Don't imply incorrect guarantees about data races. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dsymonds
Modified:
10 years ago
Reviewers:
CC:
rsc, dvyukov, gobot, golang-dev, r
Visibility:
Public.

Description

doc: Don't imply incorrect guarantees about data races. A race between a = "hello, world" and print(a) is not guaranteed to print either "hello, world" or "". Its behaviour is undefined. Fixes issue 4039.

Patch Set 1 #

Patch Set 2 : diff -r 29671078c8aa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5c4859bc123f https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 5bf4d4da76e9 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 028fd5ec99ba https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/go_mem.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years ago (2012-09-04 01:18:29 UTC) #1
r
http://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html File doc/go_mem.html (right): http://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html#newcode274 doc/go_mem.html:274: <code>"goodbye, universe"</code>, or crash.) regardless of the semantic change ...
10 years ago (2012-09-05 14:53:02 UTC) #2
dsymonds
https://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html File doc/go_mem.html (right): https://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html#newcode274 doc/go_mem.html:274: <code>"goodbye, universe"</code>, or crash.) On 2012/09/05 14:53:02, r wrote: ...
10 years ago (2012-09-05 21:58:58 UTC) #3
r
https://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html File doc/go_mem.html (right): https://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html#newcode274 doc/go_mem.html:274: <code>"goodbye, universe"</code>, or crash.) Just fix the structure. Go ...
10 years ago (2012-09-05 22:46:44 UTC) #4
dsymonds
https://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html File doc/go_mem.html (right): https://codereview.appspot.com/6489075/diff/5001/doc/go_mem.html#newcode274 doc/go_mem.html:274: <code>"goodbye, universe"</code>, or crash.) On 2012/09/05 22:46:44, r wrote: ...
10 years ago (2012-09-05 22:49:53 UTC) #5
dsymonds
Russ, Dmitry: any thoughts on this?
10 years ago (2012-09-06 22:58:41 UTC) #6
r
https://codereview.appspot.com/6489075/diff/2002/doc/go_mem.html File doc/go_mem.html (right): https://codereview.appspot.com/6489075/diff/2002/doc/go_mem.html#newcode274 doc/go_mem.html:274: crash, or do something else.) fine wording. i leave ...
10 years ago (2012-09-06 22:59:22 UTC) #7
dvyukov
Looks good
10 years ago (2012-09-07 06:51:01 UTC) #8
gobot
R=rsc (assigned by r)
10 years ago (2012-09-07 17:22:33 UTC) #9
rsc
LGTM I believe this was a dreg from when strings were single-word values.
10 years ago (2012-09-10 16:16:38 UTC) #10
dsymonds
10 years ago (2012-09-10 22:48:13 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=dbcfb4459ab8 ***

doc: Don't imply incorrect guarantees about data races.

A race between
        a = "hello, world"
and
        print(a)
is not guaranteed to print either "hello, world" or "".
Its behaviour is undefined.

Fixes issue 4039.

R=rsc
CC=dvyukov, gobot, golang-dev, r
http://codereview.appspot.com/6489075
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b