Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)

Issue 6488052: Add benchmarks for blits that test source alpha (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Antti
Modified:
11 years, 8 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add benchmarks for blits that test source alpha Overrides BitmapBench to generate four different types of source images for the following blit cases - completely opaque - completely transparent - 2 striped patterns that try to hit the worst case of state-machine based alpha prediction BUG= TEST=bench -match bitmap_8888_A_source -repeat 50

Patch Set 1 #

Patch Set 2 : add new alpha pattern "evil stripes" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -28 lines) Patch
M bench/BitmapBench.cpp View 1 6 chunks +143 lines, -28 lines 0 comments Download

Messages

Total messages: 7
Antti
Derek, could you take a look? I've also considered adding a benchmark that would do ...
11 years, 8 months ago (2012-08-29 16:28:05 UTC) #1
DerekS
On 2012/08/29 16:28:05, Antti wrote: > Derek, could you take a look? > > I've ...
11 years, 8 months ago (2012-08-29 18:58:49 UTC) #2
DerekS
On 2012/08/29 16:28:05, Antti wrote: > Derek, could you take a look? > > I've ...
11 years, 8 months ago (2012-08-29 18:59:21 UTC) #3
Antti
On 2012/08/29 18:59:21, DerekS wrote: > If you want to add the additional alpha changes ...
11 years, 8 months ago (2012-08-30 11:37:31 UTC) #4
Antti
Derek, I don't quite like the evil name, but couldn't come up with better either. ...
11 years, 8 months ago (2012-08-30 11:40:10 UTC) #5
Antti
Btw, I don't have commit rights to the repo, so if this looks good to ...
11 years, 8 months ago (2012-08-30 11:44:30 UTC) #6
DerekS
11 years, 8 months ago (2012-08-31 12:43:13 UTC) #7
On 2012/08/30 11:44:30, Antti wrote:
> Btw, I don't have commit rights to the repo, so if this looks good to you, can
> you help me commit it?

I've incorporated this change into https://codereview.appspot.com/6465075/ which
has been committed so you can close this issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b