Issue 6485072: mstate: continued completion of assign_test.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6485072: mstate: continued completion of assign_test.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by TheMue

Modified:
11 years, 8 months ago

Reviewers:
mp+121382

Visibility:
Public.

Description

mstate: continued completion of assign_test.go Added some missing tests of the AssignSuite. There are still open ones. They depend on the implementation of Unit.AssignToUnusedMachine(). Here transactions are needed (finding unused machine as 1st step, assigning id to unit in 2nd step). https://code.launchpad.net/~themue/juju-core/go-mstate-assign-test/+merge/121382 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : mstate: continued completion of assign_test.go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	mstate/assign_test.go	View		1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM Thanks for keeping an eye on pending tests, Frank.

11 years, 8 months ago (2012-08-27 15:50:34 UTC) #2

TheMue

11 years, 8 months ago (2012-08-27 16:13:20 UTC) #3

*** Submitted:

mstate: continued completion of assign_test.go

Added some missing tests of the AssignSuite. There are
still open ones. They depend on the implementation of 
Unit.AssignToUnusedMachine(). Here transactions are
needed (finding unused machine as 1st step, assigning
id to unit in 2nd step).

R=niemeyer
CC=
https://codereview.appspot.com/6485072

Expand All Messages | Collapse All Messages