Check for Fontforge with enable-double (1637)

Check for Fontforge with enable-double (1637)

configure should check whether Fontforge was built with
enable-double, to prevent strange bugs with font rendering.

[Graham Percival, 2012-08-26 22:17:03]

LGTM, I get the expected error from a stock ubuntu 12.04 (which does not include
--enable-double).

[John Mandereau, 2012-08-26 22:56:44]

LGTM except one nitpick (see comment).

http://codereview.appspot.com/6484062/diff/1/configure.in
File configure.in (right):

http://codereview.appspot.com/6484062/diff/1/configure.in#newcode174
configure.in:174: if $FONTFORGE --version 2>&1|egrep -q -e '-L?D\.?$'; then
It seems that egrep vs. grep and egrep/grep -e flag are redundant, why not just
have "grep -q -e" instead?

[dak, 2012-08-27 09:04:46]

On 2012/08/26 22:56:44, John Mandereau wrote:
> LGTM except one nitpick (see comment).
> 
> http://codereview.appspot.com/6484062/diff/1/configure.in
> File configure.in (right):
> 
> http://codereview.appspot.com/6484062/diff/1/configure.in#newcode174
> configure.in:174: if $FONTFORGE --version 2>&1|egrep -q -e '-L?D\.?$'; then
> It seems that egrep vs. grep and egrep/grep -e flag are redundant, why not
just
> have "grep -q -e" instead?

You are confusing grep -E with grep -e.  -e just says that the next word is the
regular expression to look for rather than an option, and it is required since
the regular expression starts with dash itself.

[dak, 2012-08-27 09:05:48]

On 2012/08/27 09:04:46, dak wrote:
> On 2012/08/26 22:56:44, John Mandereau wrote:
> > LGTM except one nitpick (see comment).
> > 
> > http://codereview.appspot.com/6484062/diff/1/configure.in
> > File configure.in (right):
> > 
> > http://codereview.appspot.com/6484062/diff/1/configure.in#newcode174
> > configure.in:174: if $FONTFORGE --version 2>&1|egrep -q -e '-L?D\.?$'; then
> > It seems that egrep vs. grep and egrep/grep -e flag are redundant, why not
> just
> > have "grep -q -e" instead?
> 
> You are confusing grep -E with grep -e.  -e just says that the next word is
the
> regular expression to look for rather than an option, and it is required since
> the regular expression starts with dash itself.

Actually, one should just use grep.  I just was not able to remember whether
plain grep needs ? or \? in its patterns and was too lazy to look it up.

[John Mandereau, 2012-08-27 09:52:53]

2012/8/27  <dak@gnu.org>:
> On 2012/08/27 09:04:46, dak wrote:
>> You are confusing grep -E with grep -e.  -e just says that the next
>> word is the regular expression to look for rather than an option, and it is
>> required since the regular expression starts with dash itself.
>
>
> Actually, one should just use grep.  I just was not able to remember
> whether plain grep needs ? or \? in its patterns and was too lazy to
> look it up.

After having run the test in issue 1683 and reread the report and
comments of this issue (1637), there is no evidence that we need to
check whether Fontforge was built with --enable-double or -longdouble,
so let's only bump fontforge version requirement (posted as another
Rietveld issue, before having noticed that a patch doing this had
already been posted by Graham), so this work on grep invocation
hopefully will be useful in another context.