mstate: continued completion of machine_test.go

mstate: continued completion of machine_test.go

Added missing tests and changed InstanceId() to return
a NotFoundError if it is empty. In case of a corrupt
instance id it is set to "" too, so that the error here
now also is a NotFoundError. Still some tests regarding
the alive flag are missing, the implementation of those
methods needs the presence package (or equiv).

https://code.launchpad.net/~themue/juju-core/go-mstate-machine-test/+merge/121394

(do not edit description out of merge proposal)

[TheMue, 2012-08-27 10:21:37]

Please take a look.

[niemeyer, 2012-08-27 16:03:36]

LGTM, keep it up!

https://codereview.appspot.com/6482073/diff/1/mstate/machine.go
File mstate/machine.go (right):

https://codereview.appspot.com/6482073/diff/1/mstate/machine.go#newcode44
mstate/machine.go:44: if m.doc.InstanceId == "" {
msg := fmt.Sprintf(...)
return "", &NotFoundError{msg}

[TheMue, 2012-08-27 16:18:03]

*** Submitted:

mstate: continued completion of machine_test.go

Added missing tests and changed InstanceId() to return
a NotFoundError if it is empty. In case of a corrupt
instance id it is set to "" too, so that the error here
now also is a NotFoundError. Still some tests regarding
the alive flag are missing, the implementation of those
methods needs the presence package (or equiv).

R=niemeyer
CC=
https://codereview.appspot.com/6482073

https://codereview.appspot.com/6482073/diff/1/mstate/machine.go
File mstate/machine.go (right):

https://codereview.appspot.com/6482073/diff/1/mstate/machine.go#newcode44
mstate/machine.go:44: if m.doc.InstanceId == "" {
On 2012/08/27 16:03:36, niemeyer wrote:
> msg := fmt.Sprintf(...)
> return "", &NotFoundError{msg}

Done.