Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 6479053: code review 6479053: net: fix nil pointer defererence in selfConnect for TCP (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by mikio
Modified:
9 years, 4 months ago
Reviewers:
dfc, rsc, albert.strasheim
CC:
golang-dev, aam, gobot
Visibility:
Public.

Description

net: fix nil pointer defererence in selfConnect for TCP localSockname and remoteSockname return (*TCPAddr)(nil) when syscall getsockname, getpeername fail. Fixes issue 4033.

Patch Set 1 : diff -r ca5e20f93081 https://code.google.com/p/go #

Patch Set 2 : diff -r 9e610a78455c https://code.google.com/p/go #

Total comments: 6

Patch Set 3 : diff -r 9e610a78455c https://code.google.com/p/go #

Patch Set 4 : diff -r 3181682928c9 https://code.google.com/p/go #

Total comments: 5

Patch Set 5 : diff -r 3181682928c9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
A src/pkg/net/tcp_posix_test.go View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
M src/pkg/net/tcpsock_posix.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 5 months ago (2012-08-25 08:56:37 UTC) #1
dfc
Thank you for fixing this so quickly. http://codereview.appspot.com/6479053/diff/2002/src/pkg/net/tcp_test.go File src/pkg/net/tcp_test.go (right): http://codereview.appspot.com/6479053/diff/2002/src/pkg/net/tcp_test.go#newcode121 src/pkg/net/tcp_test.go:121: func TestTCPSelfConenct(t ...
9 years, 5 months ago (2012-08-25 09:35:45 UTC) #2
mikio
http://codereview.appspot.com/6479053/diff/2002/src/pkg/net/tcp_test.go File src/pkg/net/tcp_test.go (right): http://codereview.appspot.com/6479053/diff/2002/src/pkg/net/tcp_test.go#newcode121 src/pkg/net/tcp_test.go:121: func TestTCPSelfConenct(t *testing.T) { On 2012/08/25 09:35:46, dfc wrote: ...
9 years, 5 months ago (2012-08-25 13:43:26 UTC) #3
mikio
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 5 months ago (2012-08-25 13:44:04 UTC) #4
aam
thanks to Dave Chaney who alerted me to this CL. I had built a somewhat ...
9 years, 5 months ago (2012-08-27 23:13:35 UTC) #5
mikio
Hello golang-dev@googlegroups.com, dave@cheney.net, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 5 months ago (2012-08-28 03:24:06 UTC) #6
dfc
http://codereview.appspot.com/6479053/diff/16003/src/pkg/net/tcp_posix_test.go File src/pkg/net/tcp_posix_test.go (right): http://codereview.appspot.com/6479053/diff/16003/src/pkg/net/tcp_posix_test.go#newcode19 src/pkg/net/tcp_posix_test.go:19: {&netFD{laddr: nil, raddr: nil}, nil, true}, Why do we ...
9 years, 5 months ago (2012-08-29 10:33:07 UTC) #7
mikio
Hello golang-dev@googlegroups.com, dave@cheney.net, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 5 months ago (2012-08-29 10:48:27 UTC) #8
mikio
http://codereview.appspot.com/6479053/diff/16003/src/pkg/net/tcp_posix_test.go File src/pkg/net/tcp_posix_test.go (right): http://codereview.appspot.com/6479053/diff/16003/src/pkg/net/tcp_posix_test.go#newcode19 src/pkg/net/tcp_posix_test.go:19: {&netFD{laddr: nil, raddr: nil}, nil, true}, right, I said ...
9 years, 5 months ago (2012-08-29 10:48:28 UTC) #9
dfc
On 2012/08/29 10:48:28, mikio wrote: > http://codereview.appspot.com/6479053/diff/16003/src/pkg/net/tcp_posix_test.go > File src/pkg/net/tcp_posix_test.go (right): > > http://codereview.appspot.com/6479053/diff/16003/src/pkg/net/tcp_posix_test.go#newcode19 > ...
9 years, 5 months ago (2012-08-29 10:50:38 UTC) #10
mikio
> LGTM, but maybe wait for rsc. as usual.
9 years, 5 months ago (2012-08-29 10:54:13 UTC) #11
gobot
R=rsc (assigned by rsc)
9 years, 4 months ago (2012-09-01 14:40:26 UTC) #12
dfc
On 2012/09/01 14:40:26, gobot wrote: > R=rsc (assigned by rsc) ping.
9 years, 4 months ago (2012-09-07 09:25:04 UTC) #13
rsc
I don't believe this is the correct fix. This was created by returning the typed ...
9 years, 4 months ago (2012-09-10 16:15:13 UTC) #14
albert.strasheim
ping? On 2012/09/10 16:15:13, rsc wrote: > I don't believe this is the correct fix. ...
9 years, 4 months ago (2012-09-18 08:34:22 UTC) #15
mikio
On 2012/09/10 16:15:13, rsc wrote: > I don't believe this is the correct fix. This ...
9 years, 4 months ago (2012-09-18 10:44:58 UTC) #16
mikio
9 years, 4 months ago (2012-09-18 16:36:45 UTC) #17
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b