code review 64770043: time: explicitely mention Tickers have to be stopped

time: explicitely mention Tickers have to be stopped

[patrick2, 2014-02-16 18:58:35]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2014-02-24 15:12:12]

R=rsc@golang.org (assigned by rsc@golang.org)

[rsc, 2014-02-24 15:14:42]

LGTM

[rsc, 2014-02-24 15:16:09]

Something is not right about this CL. For one thing, you have a very long diff
-r annotation, the full hash instead of the 12-byte hash. But also
4854e44b680386ac5af6f4c2a5f5408bacc50b37 is not a revision in the main repo. 

I will recreate this patch since it is only 1 line, but in the future can you
please use the standard codereview setup?

[rsc, 2014-02-24 15:18:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=7e130e3f9a4f ***

time: explicitely mention Tickers have to be stopped

LGTM=rsc
R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://codereview.appspot.com/64770043

Committer: Russ Cox <rsc@golang.org>

[gobot, 2014-02-24 16:19:01]

This CL appears to have broken the linux-amd64-race builder.

[patrick2, 2014-02-24 19:05:50]

On 2014/02/24 15:16:09, rsc wrote:
> Something is not right about this CL.

Right, I am working on a fork of codereview extension manipulating changesets
instead of local changes. But sticking to the existing workflow is a primary
goal so the discrepancies you noticed below are bugs which are or will be fixed.

> For one thing, you have a very long diff
> -r annotation, the full hash instead of the 12-byte hash.

That is fixed.

> But also
> 4854e44b680386ac5af6f4c2a5f5408bacc50b37 is not a revision in the main repo.

This was the id of the os/exec documentation changelist you merged earlier. I
will add checks to prevent this.

> I will recreate this patch since it is only 1 line, but in the future can you
> please use the standard codereview setup?

Cannot really promise that, but I will do my best not to waste your time again,
like checking hg clpatch works for me before emailing.

[rsc, 2014-02-24 19:33:38]

thanks!