Issue 6475069: CMake build rules for ASan/Android runtime.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6475069: CMake build rules for ASan/Android runtime.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by eugenis

Modified:
11 years, 8 months ago

Reviewers:
chandlerc1, samsonov, Evgeniy Stepanov

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/

Visibility:
Public.

Patch Set 3 : , #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
M	CMakeLists.txt	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	lib/asan/CMakeLists.txt	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	lib/interception/CMakeLists.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/sanitizer_common/CMakeLists.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

samsonov

LGTM http://codereview.appspot.com/6475069/diff/1/CMakeLists.txt File CMakeLists.txt (right): http://codereview.appspot.com/6475069/diff/1/CMakeLists.txt#newcode52 CMakeLists.txt:52: if(EXISTS ${LLVM_ANDROID_TOOLCHAIN_DIR}/lib/gcc/arm-linux-androideabi) Hm-m-m, does Android toolchain dir always ...

11 years, 8 months ago (2012-08-27 14:01:45 UTC) #1

Evgeniy Stepanov

11 years, 8 months ago (2012-08-27 14:18:24 UTC) #2

https://codereview.appspot.com/6475069/diff/1/CMakeLists.txt
File CMakeLists.txt (right):

https://codereview.appspot.com/6475069/diff/1/CMakeLists.txt#newcode52
CMakeLists.txt:52: if(EXISTS
${LLVM_ANDROID_TOOLCHAIN_DIR}/lib/gcc/arm-linux-androideabi)
On 2012/08/27 14:01:45, samsonov wrote:
> Hm-m-m, does Android toolchain dir always have
> lib/gcc/ in it, or it can sometimes have lib/clang/?
> That is, do we need separate CMake variable for this path?

In the distant future we can, theoretically, lose lib/gcc. This is something
Clang driver must detect.

I've changed the path to something that does not mention gcc.

https://codereview.appspot.com/6475069/diff/1/CMakeLists.txt#newcode60
CMakeLists.txt:60: # TODO: support i686 and MIPS Android toolchains
On 2012/08/27 14:01:45, samsonov wrote:
> Maybe you can add set(CAN_TARGET_ARM_ANDROID 0) to elseif()?

Done.

Expand All Messages | Collapse All Messages