Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4310)

Issue 6472060: mstate: continued completion of relation_test.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by TheMue
Modified:
11 years, 8 months ago
Reviewers:
mp+121436
Visibility:
Public.

Description

mstate: continued completion of relation_test.go Added independend relation tests and analyzed the dependencies for the missing RelationUnitSuite (see table in Google Apps). https://code.launchpad.net/~themue/juju-core/go-mstate-relation-test/+merge/121436 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : mstate: continued completion of relation_test.go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mstate/relation_test.go View 1 1 chunk +14 lines, -0 lines 0 comments Download
M mstate/state.go View 1 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 3
TheMue
Please take a look.
11 years, 8 months ago (2012-08-27 15:17:31 UTC) #1
niemeyer
LGTM
11 years, 8 months ago (2012-08-27 16:05:10 UTC) #2
TheMue
11 years, 8 months ago (2012-08-27 16:20:57 UTC) #3
*** Submitted:

mstate: continued completion of relation_test.go

Added independend relation tests and analyzed the
dependencies for the missing RelationUnitSuite
(see table in Google Apps).

R=niemeyer
CC=
https://codereview.appspot.com/6472060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b