Issue 6472053: testing: define and use all fixture methods.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6472053: testing: define and use all fixture methods.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+121205

Visibility:
Public.

Description

testing: define and use all fixture methods. When a helper suite defines only a subset of the available fixture methods, it invites problems if that subset changes. By making all helper suites define all fixture methods, we make it easy to mechanically check that a helper suite is being used correctly without going to look at the source for that suite. https://code.launchpad.net/~rogpeppe/juju-core/035-define-all-fixture-methods/+merge/121205 Requires: https://code.launchpad.net/~rogpeppe/juju-core/033-cmd-juju-test-refactor/+merge/120966 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -16 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	downloader/downloader_test.go	View		1 chunk	+21 lines, -1 line	0 comments	Download
M	environs/ec2/live_test.go	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	juju/conn_test.go	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	juju/testing/conn.go	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
M	state/presence/presence_test.go	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	state/ssh_test.go	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	store/store_test.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	testing/http.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	testing/log.go	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	testing/zk.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/charm/charm_test.go	View	1 2 3	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

11 years, 8 months ago (2012-08-29 13:42:33 UTC) #4

*** Submitted:

testing: define and use all fixture methods.

When a helper suite defines only a subset of the available
fixture methods, it invites problems if that subset changes.
By making all helper suites define all fixture methods,
we make it easy to mechanically check that
a helper suite is being used correctly without going
to look at the source for that suite.

R=niemeyer
CC=
https://codereview.appspot.com/6472053

Expand All Messages | Collapse All Messages