Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(206)

Issue 6465078: Script to sanitize source files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rmistry
Modified:
4 years, 5 months ago
CC:
skia-review_googlegroups.com, robertphillips
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The script does the following: * Adds a newline to the end of files if it does not have one. * Sets svn:eol-style to LF. * Replaces CRLF with LF. * Replaces Tabs with 4 whitespaces. * Removes trailing whitespaces. Created to fix http://code.google.com/p/skia/issues/detail?id=779 : New buildbot step that fixes and submits whitespace and newline source file fixes. Committed: https://code.google.com/p/skia/source/detail?r=5234

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -0 lines) Patch
A tools/sanitize_source_files.py View 1 2 3 4 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rmistry
11 years, 8 months ago (2012-08-21 13:58:10 UTC) #1
bsalomon
https://codereview.appspot.com/6465078/diff/2001/tools/sanitize_source_files.py File tools/sanitize_source_files.py (right): https://codereview.appspot.com/6465078/diff/2001/tools/sanitize_source_files.py#newcode129 tools/sanitize_source_files.py:129: if output == 'CRLF': I think this should be ...
11 years, 8 months ago (2012-08-21 15:02:00 UTC) #2
rmistry
https://codereview.appspot.com/6465078/diff/2001/tools/sanitize_source_files.py File tools/sanitize_source_files.py (right): https://codereview.appspot.com/6465078/diff/2001/tools/sanitize_source_files.py#newcode129 tools/sanitize_source_files.py:129: if output == 'CRLF': On 2012/08/21 15:02:01, bsalomon wrote: ...
11 years, 8 months ago (2012-08-21 16:47:19 UTC) #3
epoger
LGTM at patchset 4 https://codereview.appspot.com/6465078/diff/8001/tools/sanitize_source_files.py File tools/sanitize_source_files.py (right): https://codereview.appspot.com/6465078/diff/8001/tools/sanitize_source_files.py#newcode25 tools/sanitize_source_files.py:25: file_modifiers: list - Modifiers which ...
11 years, 8 months ago (2012-08-22 17:55:55 UTC) #4
rmistry
https://codereview.appspot.com/6465078/diff/8001/tools/sanitize_source_files.py File tools/sanitize_source_files.py (right): https://codereview.appspot.com/6465078/diff/8001/tools/sanitize_source_files.py#newcode25 tools/sanitize_source_files.py:25: file_modifiers: list - Modifiers which are applied to the ...
11 years, 8 months ago (2012-08-22 18:07:08 UTC) #5
rmistry
Submitting..
11 years, 8 months ago (2012-08-22 18:10:23 UTC) #6
status.rpni
4 years, 8 months ago (2019-08-07 19:36:04 UTC) #7
Message was sent while issue was closed.
Selesai

https://codereview.appspot.com/6465078/diff/2001/tools/sanitize_source_files.py
File tools/sanitize_source_files.py (right):

https://codereview.appspot.com/6465078/diff/2001/tools/sanitize_source_files....
tools/sanitize_source_files.py:129: if output == 'CRLF':
On 2012/08/21 16:47:20, rmistry wrote:
> <font style="vertical-align: inherit;"><font style="vertical-align:
inherit;">Pada 2012/08/21 15:02:01, bsalomon menulis:> Saya pikir ini seharusnya
jika output! = 'LF'. </font><font style="vertical-align: inherit;">Properti
dapat tidak ditentukan bukan hanya CRLF atau LF. </font><font
style="vertical-align: inherit;">Saya pikir kami ingin LF pada semua file
sumber.
> 
> </font></font>
> <font style="vertical-align: inherit;"><font style="vertical-align:
inherit;">Selesai
> </font></font>

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b