Issue 6463057: cmd/jujud: implement upgrading for the machine agent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6463057: cmd/jujud: implement upgrading for the machine agent

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+120192

Visibility:
Public.

Description

cmd/jujud: implement upgrading for the machine agent Works live, yay! https://code.launchpad.net/~rogpeppe/juju-core/023-machine-agent-upgrade/+merge/120192 Requires: https://code.launchpad.net/~rogpeppe/juju-core/021-jujud-upgrader/+merge/120089 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: implement upgrading for the machine agent #

Total comments: 4

Patch Set 3 : cmd/jujud: implement upgrading for the machine agent #

Patch Set 4 : cmd/jujud: implement upgrading for the machine agent #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -29 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1 2	3 chunks	+22 lines, -3 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 2	2 chunks	+35 lines, -10 lines	0 comments	Download
M	cmd/jujud/upgrade.go	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1	2 chunks	+44 lines, -1 line	0 comments	Download
M	worker/machiner/machiner.go	View		1 chunk	+4 lines, -11 lines	0 comments	Download
M	worker/machiner/machiner_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

https://codereview.appspot.com/6463057/diff/2001/cmd/jujud/machine.go File cmd/jujud/machine.go (right): https://codereview.appspot.com/6463057/diff/2001/cmd/jujud/machine.go#newcode52 cmd/jujud/machine.go:52: if err == nil { That's not right. We ...

11 years, 8 months ago (2012-08-17 16:04:34 UTC) #2

rog

Please take a look. https://codereview.appspot.com/6463057/diff/2001/cmd/jujud/machine.go File cmd/jujud/machine.go (right): https://codereview.appspot.com/6463057/diff/2001/cmd/jujud/machine.go#newcode52 cmd/jujud/machine.go:52: if err == nil { ...

11 years, 8 months ago (2012-08-21 10:45:17 UTC) #3

rog

11 years, 8 months ago (2012-08-21 15:54:11 UTC) #5

*** Submitted:

cmd/jujud: implement upgrading for the machine agent

Works live, yay!

R=niemeyer
CC=
https://codereview.appspot.com/6463057

Expand All Messages | Collapse All Messages