Issue 6462057: provisioning: fixed a race condition in testing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6462057: provisioning: fixed a race condition in testing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by TheMue

Modified:
11 years, 8 months ago

Reviewers:
mp+119489, fwereade, rog

Visibility:
Public.

Description

provisioning: fixed a race condition in testing The test if the provisioner and the firewaller are running had a race condition. And additional test for nil prevents this. https://code.launchpad.net/~themue/juju-core/go-provisioning-test-fix/+merge/119489 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provisioning: fixed a race condition in testing #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/provisioning_test.go	View	1	1 chunk	+16 lines, -12 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

https://codereview.appspot.com/6462057/diff/3001/cmd/jujud/provisioning_test.go File cmd/jujud/provisioning_test.go (right): https://codereview.appspot.com/6462057/diff/3001/cmd/jujud/provisioning_test.go#newcode35 cmd/jujud/provisioning_test.go:35: } else ...?

11 years, 8 months ago (2012-08-14 09:15:52 UTC) #3

rog

11 years, 8 months ago (2012-08-14 09:45:40 UTC) #4

https://codereview.appspot.com/6462057/diff/3001/cmd/jujud/provisioning_test.go
File cmd/jujud/provisioning_test.go (right):

https://codereview.appspot.com/6462057/diff/3001/cmd/jujud/provisioning_test....
cmd/jujud/provisioning_test.go:20: if p != nil && fw != nil {
I don't think this is sufficient, as discussed online. There is no guarantee
that this goroutine will see the changes made to the ProvisioningAgent by the
goroutine that called Run, as there's no synchronisation between them.

Expand All Messages | Collapse All Messages