Issue 6460118: Properly destroy local provider environment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6460118: Properly destroy local provider environment

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bcsaller

Modified:
11 years, 8 months ago

Reviewers:
hazmat, mp+120497

Visibility:
Public.

Description

Properly destroy local provider environment Stop using temp dir to hold pid Properly pass juju-directory on destory-environment https://code.launchpad.net/~bcsaller/juju/lxc-killpid/+merge/120497 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -28 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/lib/service.py	View	4 chunks	+10 lines, -17 lines	2 comments	Download
M	juju/providers/local/__init__.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	juju/providers/local/agent.py	View	2 chunks	+5 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

On 2012/08/21 05:00:11, bcsaller wrote: > Please take a look. this was one of the ...

11 years, 8 months ago (2012-08-28 13:37:12 UTC) #2

hazmat

11 years, 8 months ago (2012-08-28 14:08:22 UTC) #3

https://codereview.appspot.com/6460118/diff/1/juju/lib/service.py
File juju/lib/service.py (right):

https://codereview.appspot.com/6460118/diff/1/juju/lib/service.py#newcode112
juju/lib/service.py:112: yield self._call("kill", self.get_pid())
having seen wrap-around pid behavior where this refers to an entirely different
process, this makes me wary.

https://codereview.appspot.com/6460118/diff/1/juju/lib/service.py#newcode118
juju/lib/service.py:118: 
what happens to the stop/destroy case if the pidfile doesn't exist?

Expand All Messages | Collapse All Messages