Issue 6459100: mstate: use juju-core/testing for MongoDB

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6459100: mstate: use juju-core/testing for MongoDB

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by aram

Modified:
11 years, 8 months ago

Reviewers:
mp+120196, niemeyer

Visibility:
Public.

Description

mstate: use juju-core/testing for MongoDB Use juju-core/testing for starting MongoDB instead of starting it by hand. https://code.launchpad.net/~aramh/juju-core/52-mstate-convert-to-testing/+merge/120196 Requires: https://code.launchpad.net/~aramh/juju-core/51-testing-add-mgo/+merge/120195 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : mstate: use juju-core/testing for MongoDB #

Total comments: 2

Patch Set 3 : mstate: use juju-core/testing for MongoDB #

Total comments: 1

Patch Set 4 : mstate: use juju-core/testing for MongoDB #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -125 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mstate/conn_test.go	View	1 2	2 chunks	+14 lines, -12 lines	0 comments	Download
D	mstate/mgo_test.go	View		1 chunk	+0 lines, -93 lines	0 comments	Download
M	mstate/state_test.go	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	testing/mgo.go	View	1 2	4 chunks	+9 lines, -17 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

LGTM, assuming we have a Session in MgoSuite that can be used for these cases. ...

11 years, 8 months ago (2012-08-17 17:58:44 UTC) #2

aram

https://codereview.appspot.com/6459100/diff/1005/mstate/conn_test.go File mstate/conn_test.go (right): https://codereview.appspot.com/6459100/diff/1005/mstate/conn_test.go#newcode35 mstate/conn_test.go:35: cs.session = testing.MgoDial() On 2012/08/17 17:58:44, niemeyer wrote: > ...

11 years, 8 months ago (2012-08-21 15:43:48 UTC) #3

niemeyer

LGTM https://codereview.appspot.com/6459100/diff/6001/testing/mgo.go File testing/mgo.go (right): https://codereview.appspot.com/6459100/diff/6001/testing/mgo.go#newcode23 testing/mgo.go:23: Session *mgo.Session Sorry, I've mentioned that again in ...

11 years, 8 months ago (2012-08-23 23:09:33 UTC) #5

aram

11 years, 8 months ago (2012-08-24 09:43:08 UTC) #6

*** Submitted:

mstate: use juju-core/testing for MongoDB

Use juju-core/testing for starting MongoDB instead of starting it
by hand.

R=niemeyer
CC=
https://codereview.appspot.com/6459100

Expand All Messages | Collapse All Messages