Issue 6458161: state: add initial config map to Initialise

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6458161: state: add initial config map to Initialise (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by dave

Modified:
13 years, 6 months ago

Reviewers:
mp+120313

Visibility:
Public.

Description

state: add initial config map to Initialise state.Initialise now takes a config map that is inserted into /environment on creation. https://code.launchpad.net/~dave-cheney/juju-core/068-state-initial-config/+merge/120313 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add initial config map to Initialise #

Patch Set 3 : state: add initial config map to Initialise #

Patch Set 4 : state: add initial config map to Initialise #

Patch Set 5 : state: add initial config map to Initialise #

Patch Set 6 : state: add initial config map to Initialise #

Patch Set 7 : state: add initial config map to Initialise #

Patch Set 8 : state: add initial config map to Initialise #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -31 lines)			Patch
A	[revision details]	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/dummy/environs.go	View	1 2 3 4 5	1 chunk	+11 lines, -18 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2 3 4 5	1 chunk	+11 lines, -0 lines	0 comments	Download
M	state/open.go	View		4 chunks	+15 lines, -4 lines	0 comments	Download
M	state/state_test.go	View	1 2 3 4 5	4 chunks	+17 lines, -8 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

niemeyer

Again, LGTM to get us moving, but can we put on the agent for 1.3 ...

13 years, 6 months ago (2012-08-22 02:31:59 UTC) #5

dave_cheney.net

On 2012/08/24 01:47:09, dfc wrote: > Please take a look. Please ignore these gyrations, just ...

13 years, 6 months ago (2012-08-24 01:50:01 UTC) #7

dave_cheney.net

13 years, 6 months ago (2012-08-24 02:03:12 UTC) #9

*** Submitted:

state: add initial config map to Initialise

state.Initialise now takes a config map that is inserted into
/environment on creation.

R=niemeyer
CC=
https://codereview.appspot.com/6458161

Expand All Messages | Collapse All Messages