Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(526)

Issue 6458158: code review 6458158: net/http: fix misplaced defer and example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by dfc
Modified:
1 year, 8 months ago
Reviewers:
CC:
r, rh, iant, dsymonds, bradfitz, golang-dev
Visibility:
Public.

Description

net/http: fix misplaced defer and example

Moves the defer (again).

Also, correct the example documentation to match.

Patch Set 1 #

Patch Set 2 : diff -r 7c5f4dad8fae https://code.google.com/p/go #

Patch Set 3 : diff -r 7c5f4dad8fae https://code.google.com/p/go #

Patch Set 4 : diff -r 7c5f4dad8fae https://code.google.com/p/go #

Patch Set 5 : diff -r 7c5f4dad8fae https://code.google.com/p/go #

Patch Set 6 : diff -r ac1b735e8753 https://code.google.com/p/go #

Patch Set 7 : diff -r 4fc1c61c3c2c https://code.google.com/p/go #

Patch Set 8 : diff -r 26b62d1db69f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/net/http/example_test.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/transport_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
dfc
Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
1 year, 8 months ago #1
dsymonds
Why defer at all there? Do the io.ReadAll, then close the body, and then do ...
1 year, 8 months ago #2
dfc
On 2012/08/18 11:19:00, dsymonds wrote: > Why defer at all there? Do the io.ReadAll, then ...
1 year, 8 months ago #3
r
Either is fine, but i favor the defer-less option. -rob
1 year, 8 months ago #4
dfc
Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 8 months ago #5
bradfitz
LGTM On Aug 21, 2012 10:34 AM, <dave@cheney.net> wrote: > Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org, > ...
1 year, 8 months ago #6
dsymonds
LGTM
1 year, 8 months ago #7
dfc
On 2012/08/21 00:43:40, dsymonds wrote: > LGTM Thank you for your comments, submitting.
1 year, 8 months ago #8
dfc
Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org, dsymonds@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 8 months ago #9
dfc
1 year, 8 months ago #10
*** Submitted as http://code.google.com/p/go/source/detail?r=989f373141cc ***

net/http: fix misplaced defer and example

Moves the defer (again).

Also, correct the example documentation to match.

R=r, robert.hencke, iant, dsymonds, bradfitz
CC=golang-dev
http://codereview.appspot.com/6458158
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5