code review 6458158: net/http: fix misplaced defer and example

net/http: fix misplaced defer and example

Moves the defer (again).

Also, correct the example documentation to match.

[dfc, 2012-08-18 10:18:12]

Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-08-18 11:19:00]

Why defer at all there? Do the io.ReadAll, then close the body, and then do
the error check.

[dfc, 2012-08-20 02:08:33]

On 2012/08/18 11:19:00, dsymonds wrote:
> Why defer at all there? Do the io.ReadAll, then close the body, and then do
> the error check.

I thought that would be less clear as it would look like


        robots, err := ioutil.ReadAll(res.Body)
        res.Body.Close()
        if err != nil {
                log.Fatal(err)
        }

I'm happy to be overruled.

[r, 2012-08-20 15:34:01]

Either is fine, but i favor the defer-less option.

-rob

[dfc, 2012-08-21 00:34:43]

Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org,
dsymonds@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-08-21 00:37:23]

LGTM
 On Aug 21, 2012 10:34 AM, <dave@cheney.net> wrote:

> Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org,
> dsymonds@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**6458158/<http://codereview.appspot.com/6458158/>
>

[dsymonds, 2012-08-21 00:43:40]

LGTM

[dfc, 2012-08-21 00:51:34]

On 2012/08/21 00:43:40, dsymonds wrote:
> LGTM

Thank you for your comments, submitting.

[dfc, 2012-08-21 00:57:53]

Hello r@golang.org, robert.hencke@gmail.com, iant@golang.org,
dsymonds@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[dfc, 2012-08-21 01:47:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=989f373141cc ***

net/http: fix misplaced defer and example

Moves the defer (again).

Also, correct the example documentation to match.

R=r, robert.hencke, iant, dsymonds, bradfitz
CC=golang-dev
http://codereview.appspot.com/6458158