Issue 6458152: environs: add {Public,Private}Address() accessors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6458152: environs: add {Public,Private}Address() accessors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dave

Modified:
11 years, 8 months ago

Reviewers:
mp+120058

Visibility:
Public.

Description

environs: add {Public,Private}Address() accessors Provides a method for fetching the {Public,Private}Address() of the machine you are running on. Ideally, for ec2, the fetchMetadata method should move into goamz as our test suite is not in a position to run code on a remote machine, only observe its behaviour (ie, TestBootstrapProvisioner) https://code.launchpad.net/~dave-cheney/juju-core/067-go-environs-unit-address/+merge/120058 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add {Public,Private}Address() accessors #

Patch Set 3 : environs: add {Public,Private}Address() accessors #

Patch Set 4 : environs: add {Public,Private}Address() accessors #

Total comments: 1

Patch Set 5 : environs: add {Public,Private}Address() accessors #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -2 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2 3 4	4 chunks	+41 lines, -0 lines	0 comments	Download
M	environs/ec2/export_test.go	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	environs/ec2/image_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/local_test.go	View	1 2 3 4	3 chunks	+10 lines, -0 lines	0 comments	Download
A	environs/ec2/testdata/1.0/meta-data/local-hostname	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	environs/ec2/testdata/1.0/meta-data/public-hostname	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/interface.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6458152/diff/2002/environs/ec2/testdata/1.0/meta-data/local-hostname File environs/ec2/testdata/1.0/meta-data/local-hostname (right): https://codereview.appspot.com/6458152/diff/2002/environs/ec2/testdata/1.0/meta-data/local-hostname#newcode1 environs/ec2/testdata/1.0/meta-data/local-hostname:1: private.dummy.address.example.com Clever.

11 years, 8 months ago (2012-08-22 02:26:33 UTC) #4

dave_cheney.net

11 years, 8 months ago (2012-08-22 02:56:41 UTC) #5

*** Submitted:

environs: add {Public,Private}Address() accessors

Provides a method for fetching the {Public,Private}Address() of the machine
you are running on.

Ideally, for ec2, the fetchMetadata method should move into goamz as our test
suite is not in a position to run code on a remote machine, only observe its
behaviour (ie, TestBootstrapProvisioner)

R=niemeyer
CC=
https://codereview.appspot.com/6458152

Expand All Messages | Collapse All Messages