environs/ec2: pass sanitised config

environs/ec2: pass sanitised config

This proposal uses the previously added --env-config flag
to pass the sanitised (non secret) parts of the config
into jujud bootstrap-state via cloudinit.

https://code.launchpad.net/~dave-cheney/juju-core/065-go-environs-ec2-pass-sanitised-config/+merge/120036

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-08-17 01:43:12]

Please take a look.

[dave_cheney.net, 2012-08-17 06:12:26]

Please take a look.

[dave_cheney.net, 2012-08-17 22:44:48]

Please take a look.

[dave_cheney.net, 2012-08-20 22:12:03]

Please take a look.

[niemeyer, 2012-08-22 02:23:29]

LGTM as a way for us to get this moving, but I think there's a missing piece
that we should talk about. Won't this end up being an invalid configuration on
the server side? Having something in state.EnvironConfig() that is an invalid
configuration doesn't feel great, even though I don't have a good answer right
now.. let's see if we can find something neat in that area.

https://codereview.appspot.com/6458151/diff/6002/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/6458151/diff/6002/environs/cloudinit/cloudinit...
environs/cloudinit/cloudinit.go:59: // and inserted into the state on
initialisation.
// Config is map that is provided to juju bootstrap-state's --env-config
// option for initializing the environment configuration.

[dave_cheney.net, 2012-08-22 03:14:45]

> LGTM as a way for us to get this moving, but I think there's a missing piece
> that we should talk about. Won't this end up being an invalid configuration on
> the server side? Having something in state.EnvironConfig() that is an invalid
> configuration doesn't feel great, even though I don't have a good answer right
> now.. let's see if we can find something neat in that area.

As I understand it we have three options for passing configuration on bootstrap

1. no configuration
2. a configuration which is complete, from the perspective of config.Config; but
is not valid from the perspective of the provisioning agent
3. a complete configuration. this is the only configuration that is considered
valid by the PA.

option 3 is out of the question because it exposes secret information over a non
secure channel.

option 1 is what we are doing now.

This proposal attempts to implement option 2. From the POV of the PA, I don't
think anything changes, it still needs to wait for an environ config that it can
use.

[dave_cheney.net, 2012-08-22 03:17:59]

*** Submitted:

environs/ec2: pass sanitised config

This proposal uses the previously added --env-config flag
to pass the sanitised (non secret) parts of the config
into jujud bootstrap-state via cloudinit.

R=niemeyer
CC=
https://codereview.appspot.com/6458151