Issue 6458053: version: rename Version to Number, BinaryVersion to Binary.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
mp+117407

Visibility:
Public.

Description

version: rename Version to Number, BinaryVersion to Binary. Also implement Parse and String for Binary. https://code.launchpad.net/~rogpeppe/juju-core/version-number/+merge/117407 Requires: https://code.launchpad.net/~rogpeppe/juju-core/environs-list-tools/+merge/117305 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : version: rename Version to Number, BinaryVersion to Binary. #

Total comments: 7

Patch Set 3 : version: rename Version to Number, BinaryVersion to Binary. #

Patch Set 4 : version: rename Version to Number, BinaryVersion to Binary. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -121 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/tools.go	View	1 2	4 chunks	+17 lines, -22 lines	0 comments	Download
M	environs/tools_test.go	View	1 2	9 chunks	+32 lines, -34 lines	0 comments	Download
M	state/machine_test.go	View	1 2 3	4 chunks	+14 lines, -14 lines	0 comments	Download
M	state/util.go	View	1 2 3	1 chunk	+8 lines, -8 lines	0 comments	Download
M	state/version_test.go	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	version/version.go	View	1 2 3	3 chunks	+53 lines, -21 lines	0 comments	Download
M	version/version_test.go	View	1 2	4 chunks	+75 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Nice polishing. LGTM https://codereview.appspot.com/6458053/diff/2001/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6458053/diff/2001/environs/tools.go#newcode234 environs/tools.go:234: return toolPrefix + vers.String() + ".tgz" ...

11 years, 9 months ago (2012-07-31 18:43:52 UTC) #2

rog

Please take a look. https://codereview.appspot.com/6458053/diff/2001/version/version.go File version/version.go (right): https://codereview.appspot.com/6458053/diff/2001/version/version.go#newcode54 version/version.go:54: panic(fmt.Errorf("version: cannot parse %q: %v", ...

11 years, 9 months ago (2012-08-01 07:46:41 UTC) #3

rog

11 years, 9 months ago (2012-08-01 16:21:01 UTC) #4

*** Submitted:

version: rename Version to Number, BinaryVersion to Binary.

Also implement Parse and String for Binary.

R=niemeyer
CC=
https://codereview.appspot.com/6458053

Expand All Messages | Collapse All Messages