Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6454150: code review 6454150: go/scanner: faster scanning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by gri
Modified:
9 years, 10 months ago
Reviewers:
dsymonds
CC:
r, golang-dev
Visibility:
Public.

Description

go/scanner: faster scanning Optimize some common cases. benchmark old ns/op new ns/op delta BenchmarkScanFile 718907 667960 -7.09% benchmark old MB/s new MB/s speedup BenchmarkScanFile 23.03 25.51 1.11x

Patch Set 1 #

Patch Set 2 : diff -r f1bf0abeff93 https://code.google.com/p/go #

Patch Set 3 : diff -r f1bf0abeff93 https://code.google.com/p/go #

Patch Set 4 : diff -r f1bf0abeff93 https://code.google.com/p/go #

Patch Set 5 : diff -r ab60a1c1e9b4 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -11 lines) Patch
M src/pkg/go/scanner/scanner.go View 1 3 chunks +28 lines, -10 lines 0 comments Download
M src/pkg/go/scanner/scanner_test.go View 1 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 7
gri
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2012-08-14 16:39:28 UTC) #1
gri
Hello r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-08-14 16:40:16 UTC) #2
r
LGTM
9 years, 10 months ago (2012-08-14 18:00:14 UTC) #3
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=a14ef77ab98c *** go/scanner: faster scanning Optimize some common cases. benchmark old ns/op ...
9 years, 10 months ago (2012-08-14 18:27:00 UTC) #4
dsymonds
This CL introduced a regression. This program: package x import "time" const μs = time.Microsecond ...
9 years, 10 months ago (2012-09-05 07:13:06 UTC) #5
dsymonds
I filed http://code.google.com/p/go/issues/detail?id=4043. I'm going to take a quick stab at it now.
9 years, 10 months ago (2012-09-05 07:17:25 UTC) #6
dsymonds
9 years, 10 months ago (2012-09-05 07:21:26 UTC) #7
Sorry for the noise. Apparently I was using a client that was synced between
this bug-introducing CL and the CL that fixed it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b