Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(259)

Issue 6454084: config/environs: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dave
Modified:
11 years, 9 months ago
Reviewers:
rog, mp+117818, fwereade, TheMue
Visibility:
Public.

Description

config/environs: fix build Restore current.go which disappeared in rev 359. https://code.launchpad.net/~dave-cheney/juju-core/go-environs-config-fix/+merge/117818 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A environs/config/current.go View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dave_cheney.net
Please take a look.
11 years, 9 months ago (2012-08-01 23:48:20 UTC) #1
fwereade
LGTM
11 years, 9 months ago (2012-08-02 06:57:08 UTC) #2
TheMue
LGTM Only a go fmt missing.
11 years, 9 months ago (2012-08-02 07:10:04 UTC) #3
rog
11 years, 9 months ago (2012-08-02 07:43:16 UTC) #4
On 2012/08/01 23:48:20, dfc wrote:
> Please take a look.

doesn't LGTM.
this code is now in the version package, and everything builds ok for me, at any
rate.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b