Allow different column widths per filetype.

Allow different column widths per filetype.

BUG=143934
TEST=Create a patch containing a .java file and a .cc file, both with lines between 81 and 99 characters. View the diff and verify they render differently.

[Erik Wright, 2012-08-21 20:19:22]

maruel: This is really a strawman to get your feedback. I don't know what would
be done about user-specified column widths, but they don't seem particularly
useful in Chromium. Perhaps we can stop giving them default values and reset
them to None where they don't currently correspond to the default value? I don't
know if there is a place to define data migration code to run during upgrades...

[M-A, 2012-08-21 20:27:19]

On 2012/08/21 20:19:22, Erik Wright wrote:
> maruel: This is really a strawman to get your feedback. I don't know what
would
> be done about user-specified column widths, but they don't seem particularly
> useful in Chromium. Perhaps we can stop giving them default values and reset
> them to None where they don't currently correspond to the default value? I
don't
> know if there is a place to define data migration code to run during
upgrades...

I don't know, java devs can simply use 100 cols as their user settings and the
presubmit check will warn anyway if a line is too long.

[Erik Wright, 2012-08-21 20:28:58]

On 2012/08/21 20:27:19, M-A wrote:
> On 2012/08/21 20:19:22, Erik Wright wrote:
> > maruel: This is really a strawman to get your feedback. I don't know what
> would
> > be done about user-specified column widths, but they don't seem particularly
> > useful in Chromium. Perhaps we can stop giving them default values and reset
> > them to None where they don't currently correspond to the default value? I
> don't
> > know if there is a place to define data migration code to run during
> upgrades...
> 
> I don't know, java devs can simply use 100 cols as their user settings and the
> presubmit check will warn anyway if a line is too long.

I'm reviewing a bunch of Android upstreaming stuff, and I suspect others will be
too. Should everyone change their settings?

If we are relying on presubmit check why not just make the default 100 then?

[M-A, 2012-08-21 20:31:52]

On 2012/08/21 20:28:58, Erik Wright wrote:
> On 2012/08/21 20:27:19, M-A wrote:
> > I don't know, java devs can simply use 100 cols as their user settings and
the
> > presubmit check will warn anyway if a line is too long.
> 
> I'm reviewing a bunch of Android upstreaming stuff, and I suspect others will
be
> too. Should everyone change their settings?

Everyone = people stuck with java, which is a subset of the devs (my sympathies
btw).
 
> If we are relying on presubmit check why not just make the default 100 then?

Number of C++/python devs >> Number of java devs

[Erik Wright, 2012-08-21 20:50:28]

On 2012/08/21 20:31:52, M-A wrote:
> On 2012/08/21 20:28:58, Erik Wright wrote:
> > On 2012/08/21 20:27:19, M-A wrote:
> > > I don't know, java devs can simply use 100 cols as their user settings and
> the
> > > presubmit check will warn anyway if a line is too long.
> > 
> > I'm reviewing a bunch of Android upstreaming stuff, and I suspect others
will
> be
> > too. Should everyone change their settings?
> 
> Everyone = people stuck with java, which is a subset of the devs (my
sympathies
> btw).
>  
> > If we are relying on presubmit check why not just make the default 100 then?
> 
> Number of C++/python devs >> Number of java devs

It seems contradictory to me to say that, for those of us who review both C++
and Java, there is no problem just changing your personal settings to 100
columns, and then to say that, for the team at large, a default of 100 columns
would somehow be detrimental.

I guess I'll change my personal setting to 100 and complain later if there is a
problem with it.