juju: conn.AddUnits take a service as a string

juju: conn.AddUnits take a service as a string

This proposal is in response to http://codereview.appspot.com/6449093/
which suggested that calling conn.State() to retrieve the *Service
was a smell. Now you can call AddUnits using only the string name of the
service.

https://code.launchpad.net/~dave-cheney/juju-core/go-juju-conn-add-units-service-string/+merge/118449

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-08-07 00:41:46]

Please take a look.

[fwereade, 2012-08-07 07:29:34]

LGTM (although you should surely check with someone else, as I may have
misunderstood the intent behind juju.Conn)

[rog, 2012-08-07 08:40:40]

On 2012/08/07 07:29:34, fwereade wrote:
> LGTM (although you should surely check with someone else, as I may have
> misunderstood the intent behind juju.Conn)

I'm not so keen on this - we made a deliberate decision to expose the underlying
state.Service in the Conn API (it's returned by AddService), so I think it's
perfectly reasonable that AddUnits should act on it.

How about a convenience method, Conn.Service, that simply
calls Service on the underlying State?

Alternatively, I think it's ok if callers *do* use the underlying State too -
we're not trying to hide it.

[niemeyer, 2012-08-07 17:10:06]

We've clarified this a bit in the ML.