Issue 6452055: code review 6452055: exp/html: replace NUL with U+FFFD in text in foreign content

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by andybalholm

Modified:
11 years, 9 months ago

Reviewers:
nigeltao

CC:
golang-dev

Visibility:
Public.

exp/html: replace NUL with U+FFFD in text in foreign content Pass 5 additional tests.

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/pkg/exp/html/parse.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	src/pkg/exp/html/testlogs/plain-text-unsafe.dat.log	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 2

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2012-07-27 14:16:25 UTC) #1

LGTM.