Issue 6452051: environs/jujutest: enable PA test in ec2/live

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6452051: environs/jujutest: enable PA test in ec2/live (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dave

Modified:
11 years, 9 months ago

Reviewers:
mp+116900

Visibility:
Public.

Description

environs/jujutest: enable PA test in ec2/live Enable the provisioning agent tests in ec2 live mode. https://code.launchpad.net/~dave-cheney/juju-core/go-environs-jujutest-provisioner-tests/+merge/116900 Requires: https://code.launchpad.net/~dave-cheney/juju-core/go-juju-update-secrets/+merge/116694 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: enable PA test in ec2/live #

Patch Set 3 : environs/jujutest: enable PA test in ec2/live #

Total comments: 2

Patch Set 4 : environs/jujutest: enable PA test in ec2/live #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/config_test.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	environs/ec2/live_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6452051/diff/5001/environs/ec2/live_test.go File environs/ec2/live_test.go (right): https://codereview.appspot.com/6452051/diff/5001/environs/ec2/live_test.go#newcode58 environs/ec2/live_test.go:58: HasProvisioner: true, WOOHOO! https://codereview.appspot.com/6452051/diff/5001/environs/jujutest/livetests.go File environs/jujutest/livetests.go (right): https://codereview.appspot.com/6452051/diff/5001/environs/jujutest/livetests.go#newcode171 ...

11 years, 9 months ago (2012-07-26 16:34:40 UTC) #4

dave_cheney.net

11 years, 9 months ago (2012-07-26 17:13:00 UTC) #5

*** Submitted:

environs/jujutest: enable PA test in ec2/live

Enable the provisioning agent tests in ec2 live mode.

R=niemeyer
CC=
https://codereview.appspot.com/6452051

Expand All Messages | Collapse All Messages