Issue 6452049: provisioning: provisioner gets state as argument

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6452049: provisioning: provisioner gets state as argument (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by TheMue

Modified:
11 years, 9 months ago

Reviewers:
mp+116832

Visibility:
Public.

Description

provisioning: provisioner gets state as argument As a preparation for the integration of the firewaller into the provisioning agent provisioner has been changed to get a state instead an info as argument. So both later can share the same state. https://code.launchpad.net/~themue/juju-core/go-provisioning-state/+merge/116832 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : provisioning: provisioner gets state as argument #

Patch Set 3 : provisioning: provisioner gets state as argument #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -47 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/provisioning.go	View	1	3 chunks	+10 lines, -1 line	0 comments	Download
M	worker/provisioner/provisioner.go	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View		15 chunks	+14 lines, -39 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

https://codereview.appspot.com/6452049/diff/1/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6452049/diff/1/cmd/jujud/provisioning.go#newcode39 cmd/jujud/provisioning.go:39: st, err := state.Open(&a.Conf.StateInfo) Hmm.. I think we should ...

11 years, 9 months ago (2012-07-26 11:37:52 UTC) #2

TheMue

11 years, 9 months ago (2012-07-26 15:17:23 UTC) #6

*** Submitted:

provisioning: provisioner gets state as argument

As a preparation for the integration of the firewaller
into the provisioning agent provisioner has been changed
to get a state instead an info as argument. So both
later can share the same state.

R=niemeyer
CC=
https://codereview.appspot.com/6452049

Expand All Messages | Collapse All Messages