juju: update secrets when calling conn.State()

juju: update secrets when calling conn.State()

Calls to conn.State() push the secrets to the state
behind the scenes.

https://code.launchpad.net/~dave-cheney/juju-core/go-juju-update-secrets/+merge/116694

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-07-26 09:44:03]

Please take a look.

[dave_cheney.net, 2012-07-26 09:45:40]

Pls ignore for now. Waiting on prereqs.

On Thu, Jul 26, 2012 at 7:44 PM,  <dave@cheney.net> wrote:
> Reviewers: mp+116694_code.launchpad.net,
>
> Message:
> Please take a look.
>
> Description:
> juju: update secrets when calling conn.State()
>
> Calls to conn.State() push the secrets to the state
> behind the scenes.
>
>
https://code.launchpad.net/~dave-cheney/juju-core/go-juju-update-secrets/+mer...
>
> (do not edit description out of merge proposal)
>
>
> Please review this at https://codereview.appspot.com/6452044/
>
> Affected files:
>   A [revision details]
>   M environs/config_test.go
>   A environs/dummy/config_test.go
>   M environs/dummy/environs.go
>   M environs/dummy/environs_test.go
>   M environs/ec2/config_test.go
>   M environs/ec2/ec2.go
>   M environs/export_test.go
>   M environs/interface.go
>   M juju/conn.go
>   M juju/conn_test.go
>
>

[dave_cheney.net, 2012-07-26 13:49:59]

Please take a look.

[dave_cheney.net, 2012-07-26 13:54:10]

Please take a look.

[niemeyer, 2012-07-26 13:57:53]

https://codereview.appspot.com/6452044/diff/11001/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/6452044/diff/11001/juju/conn.go#newcode92
juju/conn.go:92: env.Update(secrets)
As we discussed live, we want to only do this if there are actually no secrets
in state yet.

[dave_cheney.net, 2012-07-26 15:35:47]

Please take a look.

[dave_cheney.net, 2012-07-26 16:35:57]

Please take a look.

[dave_cheney.net, 2012-07-26 16:55:10]

Please take a look.

[niemeyer, 2012-07-26 17:01:00]

LGTM

[dave_cheney.net, 2012-07-26 17:10:26]

*** Submitted:

juju: update secrets when calling conn.State()

Calls to conn.State() push the secrets to the state
behind the scenes.

R=niemeyer
CC=
https://codereview.appspot.com/6452044