Issue 6449043: state: move RelationScope type to charm.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449043: state: move RelationScope type to charm.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
mp+116632

Visibility:
Public.

Description

state: move RelationScope type to charm. Also make the schema error for OneOf a little more useful. https://code.launchpad.net/~rogpeppe/juju-core/charm-relationscope/+merge/116632 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: move RelationScope type to charm. #

Patch Set 3 : state: move RelationScope type to charm. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -95 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/config_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	charm/meta.go	View		5 chunks	+14 lines, -7 lines	0 comments	Download
M	charm/meta_test.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	cmd/juju/deploy_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/deploy.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/deploy_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	schema/schema.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	schema/schema_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	state/relation.go	View		3 chunks	+3 lines, -10 lines	0 comments	Download
M	state/relation_internal_test.go	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	state/relation_test.go	View		12 chunks	+17 lines, -16 lines	0 comments	Download
M	state/service_test.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/state.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/topology.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	state/topology_test.go	View		19 chunks	+37 lines, -36 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

11 years, 9 months ago (2012-07-26 18:10:10 UTC) #3

*** Submitted:

state: move RelationScope type to charm.

Also make the schema error for OneOf a little
more useful.

R=niemeyer
CC=
https://codereview.appspot.com/6449043

Expand All Messages | Collapse All Messages