Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 6448110: code review 6448110: syscall: expose socket control message helper CmsgData (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by mikio
Modified:
11 years, 7 months ago
Reviewers:
r, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

syscall: expose socket control message helper CmsgData

Patch Set 1 : diff -r b42e90a3d42f https://code.google.com/p/go #

Patch Set 2 : diff -r b42e90a3d42f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/syscall/sockcmsg_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/sockcmsg_unix.go View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 8 months ago (2012-08-03 11:06:38 UTC) #1
r
I'm pretty unhappy having a standard package export an unsafe.Pointer.
11 years, 8 months ago (2012-08-03 19:41:15 UTC) #2
mikio
On Sat, Aug 4, 2012 at 4:41 AM, <r@golang.org> wrote: > I'm pretty unhappy having ...
11 years, 7 months ago (2012-08-07 02:21:25 UTC) #3
mikio
11 years, 7 months ago (2012-08-07 02:21:52 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b