implement --format changes as discussed live

implement --format changes as discussed live

* Nothing has a --test flag
* YAML output now has trailing newlines stripped
* --format now accepts "smart", everywhere except status

https://code.launchpad.net/~fwereade/juju-core/cmd-format-smart/+merge/117493

(do not edit description out of merge proposal)

[fwereade, 2012-07-31 17:17:17]

Please take a look.

[rog, 2012-07-31 17:22:04]

On 2012/07/31 17:17:17, fwereade wrote:
> Please take a look.

LGTM.

[niemeyer, 2012-07-31 17:24:14]

Wow, that was easy. I wish we had these many removals more often. :-)

LGTM, with one item worth of attention:

https://codereview.appspot.com/6448090/diff/1/cmd/output.go
File cmd/output.go (right):

https://codereview.appspot.com/6448090/diff/1/cmd/output.go#newcode43
cmd/output.go:43: //   * anything else: delegate to FormatYaml
I'd rather keep it as *maps* only, and break if we get something unknown, so
that we perceive when something crackful is getting through by mistake.

https://codereview.appspot.com/6448090/diff/1/cmd/output.go#newcode51
cmd/output.go:51: // FormatYaml works as specified for int, float, bool; may as
well use it.
That sounds fine still. We should just test that these are what we're handing
off indeed.

https://codereview.appspot.com/6448090/diff/1/cmd/output_test.go
File cmd/output_test.go (right):

https://codereview.appspot.com/6448090/diff/1/cmd/output_test.go#newcode62
cmd/output_test.go:62: {[]string{"blam", "dink"}, "blam\ndink\n"},
Cool stuff. These tests look great.

[fwereade, 2012-07-31 18:52:41]

*** Submitted:

implement --format changes as discussed live

* Nothing has a --test flag
* YAML output now has trailing newlines stripped
* --format now accepts "smart", everywhere except status

R=rog, niemeyer
CC=
https://codereview.appspot.com/6448090

https://codereview.appspot.com/6448090/diff/1/cmd/output.go
File cmd/output.go (right):

https://codereview.appspot.com/6448090/diff/1/cmd/output.go#newcode43
cmd/output.go:43: //   * anything else: delegate to FormatYaml
On 2012/07/31 17:24:14, niemeyer wrote:
> I'd rather keep it as *maps* only, and break if we get something unknown, so
> that we perceive when something crackful is getting through by mistake.

Done.

https://codereview.appspot.com/6448090/diff/1/cmd/output.go#newcode51
cmd/output.go:51: // FormatYaml works as specified for int, float, bool; may as
well use it.
On 2012/07/31 17:24:14, niemeyer wrote:
> That sounds fine still. We should just test that these are what we're handing
> off indeed.

Done.

[dave_cheney.net, 2012-08-01 00:47:37]

LGTM. Thanks.

[dave_cheney.net, 2012-08-01 00:47:38]

LGTM. Thanks.