Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(617)

Issue 6447054: state: implement MachineInfoWatcher

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by rog
Modified:
8 years ago
Reviewers:
mp+117023
Visibility:
Public.

Description

state: implement MachineInfoWatcher https://code.launchpad.net/~rogpeppe/juju-core/machine-info-watcher/+merge/117023 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: implement MachineInfoWatcher #

Total comments: 2

Patch Set 3 : state: implement MachineInfoWatcher #

Patch Set 4 : state: implement MachineInfoWatcher #

Total comments: 6

Patch Set 5 : state: implement MachineInfoWatcher #

Patch Set 6 : state: implement MachineInfoWatcher #

Total comments: 1

Patch Set 7 : state: implement MachineInfoWatcher #

Patch Set 8 : state: implement MachineInfoWatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -30 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/status.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M environs/jujutest/livetests.go View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M state/confignode.go View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M state/machine.go View 1 2 3 4 5 6 7 3 chunks +10 lines, -13 lines 0 comments Download
M state/machine_test.go View 1 2 3 4 4 chunks +112 lines, -3 lines 0 comments Download
M state/util.go View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M state/watcher.go View 1 2 3 4 5 1 chunk +41 lines, -0 lines 0 comments Download
M version/version.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner.go View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
rog
Please take a look.
8 years ago (2012-07-27 09:33:29 UTC) #1
niemeyer
https://codereview.appspot.com/6447054/diff/2001/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6447054/diff/2001/state/machine.go#newcode109 state/machine.go:109: func (m *Machine) WatchInfo() *MachineInfoWatcher { s/WatchInfo/Watch/ s/MachineInfoWatcher/MachineWatcher/ https://codereview.appspot.com/6447054/diff/2001/state/watcher.go ...
8 years ago (2012-07-27 13:07:17 UTC) #2
rog
Please take a look.
8 years ago (2012-07-27 15:53:50 UTC) #3
niemeyer
Almost there. https://codereview.appspot.com/6447054/diff/19/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6447054/diff/19/state/machine.go#newcode80 state/machine.go:80: if _, ok := err.(*NotFoundError); ok || ...
8 years ago (2012-07-30 15:52:59 UTC) #4
rog
https://codereview.appspot.com/6447054/diff/19/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6447054/diff/19/state/watcher.go#newcode435 state/watcher.go:435: // Currently, alterations to AgentVersion and ProposedAgentVersion On 2012/07/30 ...
8 years ago (2012-07-30 16:48:49 UTC) #5
rog
Please take a look. https://codereview.appspot.com/6447054/diff/19/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6447054/diff/19/state/machine.go#newcode80 state/machine.go:80: if _, ok := err.(*NotFoundError); ...
8 years ago (2012-07-30 17:07:51 UTC) #6
niemeyer
LGTM, except for the minor typo: https://codereview.appspot.com/6447054/diff/36/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6447054/diff/36/state/machine.go#newcode67 state/machine.go:67: // If the ...
8 years ago (2012-07-30 17:15:14 UTC) #7
rog
8 years ago (2012-07-30 17:31:41 UTC) #8
*** Submitted:

state: implement MachineInfoWatcher

R=niemeyer
CC=
https://codereview.appspot.com/6447054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b