Issue 6446045: Fix get_constraint_set in openstack provider

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446045: Fix get_constraint_set in openstack provider

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by gz

Modified:
11 years, 9 months ago

Reviewers:
hazmat, mp+116701

Visibility:
Public.

Description

Fix get_constraint_set in openstack provider Just a tyop, also adds some basic testing of the method. https://code.launchpad.net/~gz/juju/os_constraint_typo/+merge/116701 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/openstack/provider.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/providers/openstack/tests/test_provider.py	View	2 chunks	+25 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

lgtm, thanks! https://codereview.appspot.com/6446045/diff/1/juju/providers/openstack/tests/test_provider.py File juju/providers/openstack/tests/test_provider.py (right): https://codereview.appspot.com/6446045/diff/1/juju/providers/openstack/tests/test_provider.py#newcode126 juju/providers/openstack/tests/test_provider.py:126: def test_once(self): test once could and should ...

11 years, 9 months ago (2012-07-25 17:16:07 UTC) #2

hazmat

11 years, 9 months ago (2012-07-25 17:22:24 UTC) #3

*** Submitted:

Fix get_constraint_set in openstack provider

Just a tyop, also adds some basic testing of the method directly on the 
provider.

R=hazmat
CC=
https://codereview.appspot.com/6446045

Expand All Messages | Collapse All Messages