Issue 6445054: cmd/5l, cmd/ld: support thumb properly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6445054: cmd/5l, cmd/ld: support thumb properly

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by minux1

Modified:
14 years, 3 months ago

Reviewers:

Visibility:
Public.

Description

cmd/5l, cmd/ld: support thumb properly Superseded CL 6208077. PS 10: 5l/asm.c: TODO: R_ARM_THM_PC22: still need to handle thumb calls within a object file. still missing veneer generation code. R_ARM_PLT32??

Patch Set 1 #

Patch Set 2 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 3 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 4 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 5 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 6 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 7 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 8 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 9 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Patch Set 10 : diff -r a36c0344826a ssh://hg@bitbucket.org/minux/mygo #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -35 lines)			Patch
M	src/cmd/5l/5.out.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/5l/asm.c	View	1 2 3 4 5 6 7 8 9	8 chunks	+76 lines, -27 lines	0 comments	Download
M	src/cmd/5l/l.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/6l/l.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8l/l.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/ldelf.c	View	1 2 3 4 5 6 7 8 9	6 chunks	+55 lines, -4 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1 2 3 4 5	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/cmd/ld/symtab.c	View	1 2 3 4 5 6	1 chunk	+2 lines, -2 lines	0 comments	Download