testing: add MongoDB support

testing: add MongoDB support



https://code.launchpad.net/~aramh/juju-core/51-testing-add-mgo/+merge/120195

(do not edit description out of merge proposal)

[aram, 2012-08-17 17:13:17]

Please take a look.

[niemeyer, 2012-08-17 17:44:31]

This looks nice, but there's very relevant logic in mgo_test that should remain.
I've avoided a non-trivial number of bugs by being told immediately when a
session wasn't properly closed.

https://codereview.appspot.com/6443148/diff/2001/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6443148/diff/2001/testing/mgo.go#newcode15
testing/mgo.go:15: // MgoTestPackage.
s/MgoTestPackage/StartMgoServer/

https://codereview.appspot.com/6443148/diff/2001/testing/mgo_test.go
File testing/mgo_test.go (right):

https://codereview.appspot.com/6443148/diff/2001/testing/mgo_test.go#newcode9
testing/mgo_test.go:9: type M struct{}
mgoSuite

https://codereview.appspot.com/6443148/diff/2001/testing/zk_test.go
File testing/zk_test.go (right):

https://codereview.appspot.com/6443148/diff/2001/testing/zk_test.go#newcode11
testing/zk_test.go:11: type Z struct{}
zkSuite

[aram, 2012-08-21 15:16:38]

> This looks nice, but there's very relevant logic in mgo_test that
> should remain.  I've avoided a non-trivial number of bugs by being
> told immediately when a session wasn't properly closed.

Done.

[aram, 2012-08-21 15:17:01]

https://codereview.appspot.com/6443148/diff/2001/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6443148/diff/2001/testing/mgo.go#newcode15
testing/mgo.go:15: // MgoTestPackage.
On 2012/08/17 17:44:31, niemeyer wrote:
> s/MgoTestPackage/StartMgoServer/

Done.

https://codereview.appspot.com/6443148/diff/2001/testing/mgo_test.go
File testing/mgo_test.go (right):

https://codereview.appspot.com/6443148/diff/2001/testing/mgo_test.go#newcode9
testing/mgo_test.go:9: type M struct{}
On 2012/08/17 17:44:31, niemeyer wrote:
> mgoSuite

Done.

https://codereview.appspot.com/6443148/diff/2001/testing/zk_test.go
File testing/zk_test.go (right):

https://codereview.appspot.com/6443148/diff/2001/testing/zk_test.go#newcode11
testing/zk_test.go:11: type Z struct{}
On 2012/08/17 17:44:31, niemeyer wrote:
> zkSuite

Done.

[aram, 2012-08-22 18:57:10]

Please take a look.

[niemeyer, 2012-08-23 23:08:14]

LGTM

Would you mind to just unify the two suites into one before merging?

https://codereview.appspot.com/6443148/diff/9001/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/6443148/diff/9001/testing/mgo.go#newcode123
testing/mgo.go:123: func (s *MgoSessionSuite) SetUpSuite(c *C) {
We don't need two different suites just to have a MgoSession parameter on it. We
can trivially have a Session (no need for the Mgo prefix) field on the one suite
we have.

[aram, 2012-08-24 09:41:18]

*** Submitted:

testing: add MongoDB support

R=niemeyer
CC=
https://codereview.appspot.com/6443148