state: make agents have proposed tools not versions.

state: make agents have proposed tools not versions.

With the proposed upgrade changes, we want to propose
a version of the tools and a URL to find the tools.
To do that, we move the Tool type into state and
make the old agentVersion type use it, renaming
it to agentTools.

https://code.launchpad.net/~rogpeppe/juju-core/state-propose-tools/+merge/117482

Requires: https://code.launchpad.net/~rogpeppe/juju-core/version-number/+merge/117407

(do not edit description out of merge proposal)

[rog, 2012-07-31 16:33:54]

Please take a look.

[niemeyer, 2012-07-31 18:57:46]

Nice changes too. LGTM.

https://codereview.appspot.com/6441078/diff/1001/state/tools_test.go
File state/tools_test.go (right):

https://codereview.appspot.com/6441078/diff/1001/state/tools_test.go#newcode11
state/tools_test.go:11: AgentTools() (*state.Tools, error)
Nice.

https://codereview.appspot.com/6441078/diff/1001/state/util.go
File state/util.go (right):

https://codereview.appspot.com/6441078/diff/1001/state/util.go#newcode136
state/util.go:136: defer errorContextf(&err, "cannot set %s agent %s tools",
at.agent, prefix)
"cannot set %s tools for %s agent", prefix, at.agent?

[rog, 2012-08-01 13:59:27]

Please take a look.

https://codereview.appspot.com/6441078/diff/1001/state/util.go
File state/util.go (right):

https://codereview.appspot.com/6441078/diff/1001/state/util.go#newcode136
state/util.go:136: defer errorContextf(&err, "cannot set %s agent %s tools",
at.agent, prefix)
On 2012/07/31 18:57:46, niemeyer wrote:
> "cannot set %s tools for %s agent", prefix, at.agent?

Done.

[rog, 2012-08-01 17:10:05]

*** Submitted:

state: make agents have proposed tools not versions.

With the proposed upgrade changes, we want to propose
a version of the tools and a URL to find the tools.
To do that, we move the Tool type into state and
make the old agentVersion type use it, renaming
it to agentTools.

R=niemeyer
CC=
https://codereview.appspot.com/6441078