Issue 6441059: container: add ToolsDir method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6441059: container: add ToolsDir method

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
mp+117041

Visibility:
Public.

Description

container: add ToolsDir method This allows the machine agent to copy tools into the correct directory for a unit. https://code.launchpad.net/~rogpeppe/juju-core/container-toolsdir/+merge/117041 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : container: add ToolsDir method #

Total comments: 6

Patch Set 3 : container: add ToolsDir method #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/container.go	View	1 2	2 chunks	+13 lines, -2 lines	0 comments	Download
M	container/container_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM with a few trivials: https://codereview.appspot.com/6441059/diff/2001/container/container.go File container/container.go (right): https://codereview.appspot.com/6441059/diff/2001/container/container.go#newcode15 container/container.go:15: // Deploy deploys a ...

11 years, 9 months ago (2012-07-27 11:32:27 UTC) #2

rog

11 years, 9 months ago (2012-07-27 11:47:47 UTC) #3

*** Submitted:

container: add ToolsDir method

This allows the machine agent to copy tools into the correct directory
for a unit.

R=niemeyer
CC=
https://codereview.appspot.com/6441059

https://codereview.appspot.com/6441059/diff/2001/container/container.go
File container/container.go (right):

https://codereview.appspot.com/6441059/diff/2001/container/container.go#newco...
container/container.go:15: // Deploy deploys a unit running in a container.
On 2012/07/27 11:32:27, niemeyer wrote:
> This can make good use of parameter names.
> 
> // Deploy deploys unit into a new container.
> Deploy(unit *state.Unit)
> 
> Also, some spacing between methods would make it slightly cleaner.

Done.

https://codereview.appspot.com/6441059/diff/2001/container/container.go#newco...
container/container.go:18: Destroy(*state.Unit) error
On 2012/07/27 11:32:27, niemeyer wrote:
> // Destroy destroy unit's container.

Done.

https://codereview.appspot.com/6441059/diff/2001/container/container.go#newco...
container/container.go:20: // are stored in for the given unit, relative to the
base root directory.
On 2012/07/27 11:32:27, niemeyer wrote:
> "the base root directory" can mean multiple things (base root of the
container,
> or base root of the outside filesystem? I suggest finishing the sentence at
> "given unit."

Done.

Expand All Messages | Collapse All Messages