Issue 6441053: state: add an agentVersion type and embed it into Machine.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6441053: state: add an agentVersion type and embed it into Machine.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
mp+116924

Visibility:
Public.

Description

state: add an agentVersion type and embed it into Machine. https://code.launchpad.net/~rogpeppe/juju-core/machine-agent-version/+merge/116924 Requires: https://code.launchpad.net/~rogpeppe/juju-core/state-getconfigstring/+merge/116871 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add an agentVersion type and embed it into Machine. #

Patch Set 3 : state: add an agentVersion type and embed it into Machine. #

Total comments: 1

Patch Set 4 : state: add an agentVersion type and embed it into Machine. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -10 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/export_test.go	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	state/machine.go	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
M	state/state.go	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	state/unit.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	state/util.go	View	1	2 chunks	+49 lines, -0 lines	0 comments	Download
A	state/version_test.go	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download
M	state/watcher.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6441053/diff/4001/state/version_test.go File state/version_test.go (right): https://codereview.appspot.com/6441053/diff/4001/state/version_test.go#newcode21 state/version_test.go:21: func testVersion(c *C, obj versioner, agent string) { ...

11 years, 9 months ago (2012-07-26 18:27:47 UTC) #3

rog

11 years, 9 months ago (2012-07-26 18:37:29 UTC) #4

*** Submitted:

state: add an agentVersion type and embed it into Machine.

R=niemeyer
CC=
https://codereview.appspot.com/6441053

Expand All Messages | Collapse All Messages