Issue 64390044: code review 64390044: go.crypto/ssh: build tests on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 64390044: code review 64390044: go.crypto/ssh: build tests on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by 0intro

Modified:
12 years, 8 months ago

Reviewers:
minux1

CC:
golang-codereviews, minux1

Visibility:
Public.

Description

go.crypto/ssh: build tests on Plan 9

Patch Set 1 #

Patch Set 2 : diff -r dc7486a41a09 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r dc7486a41a09 https://code.google.com/p/go.crypto #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ssh/test/forward_unix_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	ssh/test/test_unix_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto

12 years, 8 months ago (2014-02-15 18:55:12 UTC) #1

0intro

Could someone review this? It fixes go.crypto tests on Plan 9. Thanks.

12 years, 8 months ago (2014-02-19 09:40:24 UTC) #2

0intro

12 years, 8 months ago (2014-02-19 19:52:08 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=7aa593ce8cea&repo=crypto ***

go.crypto/ssh: build tests on Plan 9

LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/64390044

Expand All Messages | Collapse All Messages