Issue 6437044: cmd/juju: status: gather basic service properties

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6437044: cmd/juju: status: gather basic service properties (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dave

Modified:
11 years, 9 months ago

Reviewers:
mp+116511

Visibility:
Public.

Description

cmd/juju: status: gather basic service properties This proposal adds basic capabilities to report details about services. https://code.launchpad.net/~dave-cheney/juju-core/go-cmd-juju-status-services-part-one/+merge/116511 Requires: https://code.launchpad.net/~dave-cheney/juju-core/go-cmd-juju-status-yaml-json-fix/+merge/116495 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8

Patch Set 2 : cmd/juju: status: gather basic service properties #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -7 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/status.go	View	1	4 chunks	+52 lines, -5 lines	0 comments	Download
M	cmd/juju/status_test.go	View	1	2 chunks	+44 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM assuming the following details are sorted: https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go File cmd/juju/status.go (right): https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go#newcode109 cmd/juju/status.go:109: // fetchAllServices ...

11 years, 9 months ago (2012-07-25 09:47:27 UTC) #2

dave_cheney.net

11 years, 9 months ago (2012-07-25 10:11:50 UTC) #3

*** Submitted:

cmd/juju: status: gather basic service properties

This proposal adds basic capabilities to report
details about services.

R=niemeyer
CC=
https://codereview.appspot.com/6437044

https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go
File cmd/juju/status.go (right):

https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go#newcode109
cmd/juju/status.go:109: // fetchAllServices returns a map[int]*state.Service
representing
On 2012/07/25 09:47:27, niemeyer wrote:
> s/map[int]*State.Service/map/

Done.

https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go#newcode178
cmd/juju/status.go:178: r[s.Name()], _ = processService(s, machines)
On 2012/07/25 09:47:27, niemeyer wrote:
> err should not be ignored.

Done.

https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go#newcode183
cmd/juju/status.go:183: func processService(service *state.Service, machines
map[int]*state.Machine) (map[string]interface{}, error) {
On 2012/07/25 09:47:27, niemeyer wrote:
> Why do we need machines? Ditto for processServices.

Good point, I've removed them until there is a need.

https://codereview.appspot.com/6437044/diff/1/cmd/juju/status.go#newcode194
cmd/juju/status.go:194: if exposed {
On 2012/07/25 09:47:27, niemeyer wrote:
> I suggest having it always in the map (even if that's not done in Python
today).

Done.

Expand All Messages | Collapse All Messages