Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(293)

Issue 6432063: Documentation for cross staff stems (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by PhilEHolmes
Modified:
6 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Updated the documentation to take account of the new cross staff stem feature.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -38 lines) Patch
M Documentation/changes.tely View 1 chunk +7 lines, -0 lines 0 comments Download
M Documentation/notation/keyboards.itely View 1 chunk +9 lines, -35 lines 6 comments Download
M Documentation/snippets/new/cross-staff-stems.ly View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4
PhilEHolmes
Please review my attempt at some documentation.
6 years, 11 months ago (2012-07-23 16:01:10 UTC) #1
Jean-Charles
Just to be sure I understand correctly! http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely#newcode426 Documentation/notation/keyboards.itely:426: automatic beams ...
6 years, 11 months ago (2012-07-23 18:36:00 UTC) #2
Keith
http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (left): http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely#oldcode457 Documentation/notation/keyboards.itely:457: {indicating-cross-staff-chords-with-arpeggio-bracket.ly} I suggest keeping this in the documentation. It ...
6 years, 11 months ago (2012-07-23 18:58:02 UTC) #3
PhilEHolmes
6 years, 11 months ago (2012-07-25 09:34:58 UTC) #4
Updates from comments.

http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards...
File Documentation/notation/keyboards.itely (left):

http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards...
Documentation/notation/keyboards.itely:457:
{indicating-cross-staff-chords-with-arpeggio-bracket.ly}
Willdo.

http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards...
File Documentation/notation/keyboards.itely (right):

http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards...
Documentation/notation/keyboards.itely:426: automatic beams do not beam the
notes on one staff when it’s not
The code will automatically appear in the documentation, because of the
[verbatim] so this should make it clear.

http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards...
Documentation/notation/keyboards.itely:429: @snippets
Don't think I understand 'opposite side'.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b