Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 6430064: code review 6430064: debug/elf: Add support for getting DynTag string table ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by Mike.Rosset
Modified:
9 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

debug/elf: Add support for getting DynTag string table values.

Patch Set 1 #

Patch Set 2 : diff -r 64195dbf632d https://code.google.com/p/go #

Patch Set 3 : diff -r 64195dbf632d https://code.google.com/p/go #

Total comments: 6

Patch Set 4 : diff -r 80c98738fdde https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M src/pkg/debug/elf/file.go View 1 2 3 2 chunks +22 lines, -9 lines 0 comments Download
M src/pkg/debug/elf/file_test.go View 1 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Mike.Rosset
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-07-23 11:52:33 UTC) #1
rsc
Thanks for working on this. http://codereview.appspot.com/6430064/diff/4001/src/pkg/debug/elf/file.go File src/pkg/debug/elf/file.go (right): http://codereview.appspot.com/6430064/diff/4001/src/pkg/debug/elf/file.go#newcode732 src/pkg/debug/elf/file.go:732: // Returns the string ...
9 years, 6 months ago (2012-07-30 01:13:21 UTC) #2
Mike.Rosset
http://codereview.appspot.com/6430064/diff/4001/src/pkg/debug/elf/file.go File src/pkg/debug/elf/file.go (right): http://codereview.appspot.com/6430064/diff/4001/src/pkg/debug/elf/file.go#newcode732 src/pkg/debug/elf/file.go:732: // Returns the string table values for a DynTag ...
9 years, 6 months ago (2012-07-30 07:46:56 UTC) #3
Mike.Rosset
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-07-30 07:48:06 UTC) #4
rsc
LGTM
9 years, 5 months ago (2012-08-03 18:45:21 UTC) #5
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=16ea5989afbe *** debug/elf: Add support for getting DynTag string table values. R=rsc ...
9 years, 5 months ago (2012-08-03 18:46:23 UTC) #6
Mike.Rosset
9 years, 3 months ago (2012-10-04 15:33:16 UTC) #7
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b